Repository navigation
Uppercase first letter of diagnostics - #784
Conversation
|
@swift-ci Please test |
|
My concern here is that the first word in the diagnostic might be a keyword or identifier that shouldn't be modified. If this is preferred style, why not update the compiler diagnostics themselves? |
3e3b101 to
7047bc3
Compare
|
@swift-ci Please test |
|
I think on the command line we want to emit diagnostics that start with a lowercase letter to match clang. But in IDEs the errors show up more nicely if they start with an uppercase letter. If the diagnostic starts with an identifier or keyword, that identifier/keyword should be wrapped in single quotes, which means that the quote would be the first character, so we wouldn’t uppercase the identifier or keyword. |
7047bc3 to
188677f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Do you know if this is actually true? Might be worth bringing up the conversation. FWIW someone actually did the imperative switch: swiftlang/swift#67909 :) |
188677f to
d52df40
Compare
|
@swift-ci Please test |
d52df40 to
0b911f6
Compare
|
@swift-ci Please test |
sourcekitd returns diagnostics with the first letter lowercase. Xcode, for example, shows the messages with the first letter uppercases. I think that looks nicer and we should also uppercase the first letter in sourcekit-lsp.
0b911f6 to
d4f304e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
3 participants
sourcekitd returns diagnostics with the first letter lowercase. Xcode, for example, shows the messages with the first letter uppercases. I think that looks nicer and we should also uppercase the first letter in sourcekit-lsp.
CC @tristanlabelle I noticed this in swiftlang/swift#67510. While it doesn’t change the messages to be imperative, having them start with an uppercase letter maybe makes them stick out a little less.